fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2025-12-20 12:50:06 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

tests: let "run-nm-test.sh" fail with exit code 1 on failure

Browse source 
`git bisect run` is peculiar about the exit code:

  error: bisect run failed: exit code 134 from '...' is < 0 or >= 128

If we just "exec" the test, it usually will fail on an assert. That results
in SIGABRT or exit code 134. So out of the box that is annoying with
git-bisect.

Work around that and let the test wrapper always coerce any test failure
to exit code 1.
This commit is contained in:
Thomas Haller 2022-02-03 22:23:44 +01:00
parent a1abb3ebdf
commit f65747f6e9
No known key found for this signature in database
GPG key ID: 29C2366E4DFC5728
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
tools/run-nm-test.sh
View file

@ -300,9 +300,10 @@ fi
if ! _is_true "$NMTST_USE_VALGRIND" 0; then
export NM_TEST_UNDER_VALGRIND=0
exec "${NMTST_DBUS_RUN_SESSION[@]}" \
"$TEST" "${TEST_ARGV[@]}"
die "exec \"$TEST\" failed"
"${NMTST_DBUS_RUN_SESSION[@]}" "$TEST" "${TEST_ARGV[@]}"
r=$?
[ $r == 0 ] || die "exec \"$TEST\" failed with exit code $r"
exit 0
fi
if [[ -z "${NMTST_VALGRIND}" ]]; then