From f5685e5bc96d59c36fc9499b410bd8699afe13a8 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Thu, 6 May 2021 17:05:45 +0200 Subject: [PATCH] ifcfg-rh: add comment about unreachable code in write_bridge_vlans() --- src/core/settings/plugins/ifcfg-rh/nms-ifcfg-rh-writer.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/core/settings/plugins/ifcfg-rh/nms-ifcfg-rh-writer.c b/src/core/settings/plugins/ifcfg-rh/nms-ifcfg-rh-writer.c index 4338c30593..3d02ddbd4f 100644 --- a/src/core/settings/plugins/ifcfg-rh/nms-ifcfg-rh-writer.c +++ b/src/core/settings/plugins/ifcfg-rh/nms-ifcfg-rh-writer.c @@ -1572,8 +1572,11 @@ write_bridge_vlans(NMSetting * setting, vlan = vlans->pdata[i]; vlan_str = nm_bridge_vlan_to_str(vlan, error); - if (!vlan_str) - return FALSE; + if (!vlan_str) { + /* nm_bridge_vlan_to_str() cannot fail (for now). */ + nm_assert_not_reached(); + continue; + } if (strbuf.len > 0) nm_str_buf_append_c(&strbuf, ','); nm_str_buf_append(&strbuf, nm_utils_escaped_tokens_escape_unnecessary(vlan_str, ","));