From f4f4ecf159266ddb902eadbe00e3b2a7d24d3fc1 Mon Sep 17 00:00:00 2001 From: Dan Winship Date: Thu, 12 Jun 2014 12:21:59 -0400 Subject: [PATCH] settings: remove an unnecessary check Coverity gets confused and thinks we are potentially leaking bssid_str here. Given that nm_utils_hwaddr_ntoa() never returns NULL anyway, just drop the check. --- src/settings/nm-settings-connection.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/settings/nm-settings-connection.c b/src/settings/nm-settings-connection.c index 63b6a09b19..d20dbc9846 100644 --- a/src/settings/nm-settings-connection.c +++ b/src/settings/nm-settings-connection.c @@ -1815,7 +1815,6 @@ nm_settings_connection_add_seen_bssid (NMSettingsConnection *connection, /* Add the new BSSID; let the hash take ownership of the allocated BSSID string */ bssid_str = nm_utils_hwaddr_ntoa (seen_bssid, ARPHRD_ETHER); - g_return_if_fail (bssid_str != NULL); g_hash_table_insert (priv->seen_bssids, mac_dup (seen_bssid), bssid_str); /* Build up a list of all the BSSIDs in string form */