From f43af853e627818eafca361ad4eef3685dd5040b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=8D=C3=B1igo=20Huguet?= Date: Fri, 27 Dec 2024 09:08:43 +0100 Subject: [PATCH] ci: make check-tree optional for branches other than main Old branches tend to be formatted with a different versions of clang-format, so when patches are backported, they introduce some differences in formatting, making the check-tree job to fail. These changes in formatting are normally small, and we don't pay much attention to them, causing that the pipelines are always red, increasing the work required to check if there are important failures or not. Make check-tree optional for branches other than main. This way, failures will be shown as a "warning", and if a pipeline only shows a warning we don't need to inspect it. (cherry picked from commit 9e47c9bc6aecd3a6621d4702a8299b18ce199619) (cherry picked from commit b497ce4372e09be11399a55ac05e7de6eb845c04) --- .gitlab-ci.yml | 16 +++++++++++----- .gitlab-ci/ci.template | 6 ++++++ 2 files changed, 17 insertions(+), 5 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index dac035e204..c8b7950094 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -57,11 +57,11 @@ variables: # # This is done by running `ci-fairy generate-template` and possibly bumping # ".default_tag". - ALPINE_TAG: 'tag-b3cc86eaf091' - CENTOS_TAG: 'tag-2d6bba92b287' - DEBIAN_TAG: 'tag-1a37d0dc09ec' - FEDORA_TAG: 'tag-2d6bba92b287' - UBUNTU_TAG: 'tag-1a37d0dc09ec' + ALPINE_TAG: 'tag-db0c946f2a8f' + CENTOS_TAG: 'tag-8ae3df5458ca' + DEBIAN_TAG: 'tag-6b66f9d165ff' + FEDORA_TAG: 'tag-8ae3df5458ca' + UBUNTU_TAG: 'tag-6b66f9d165ff' ALPINE_EXEC: 'bash .gitlab-ci/alpine-install.sh' CENTOS_EXEC: 'bash .gitlab-ci/fedora-install.sh' @@ -384,6 +384,12 @@ check-tree: FDO_DISTRIBUTION_TAG: $FEDORA_TAG needs: - "tier1:fedora:40@prep" + rules: + - if: $CI_PIPELINE_SOURCE == 'merge_request_event' && $CI_MERGE_REQUEST_TARGET_BRANCH_NAME != $CI_DEFAULT_BRANCH + allow_failure: true + - if: $CI_PIPELINE_SOURCE == 'push' && $CI_COMMIT_BRANCH != $CI_DEFAULT_BRANCH + allow_failure: true + - if: $CI_PIPELINE_SOURCE != 'schedule' stage: tier1 script: - date '+%Y%m%d-%H%M%S'; clang-format --version diff --git a/.gitlab-ci/ci.template b/.gitlab-ci/ci.template index 7a0eeb308c..65376ff13a 100644 --- a/.gitlab-ci/ci.template +++ b/.gitlab-ci/ci.template @@ -205,6 +205,12 @@ check-tree: FDO_DISTRIBUTION_TAG: ${{default_distro.name.upper()}}_TAG needs: - "tier{{default_distro.tier}}:{{default_distro.name}}:{{default_distro.versions[0]}}@prep" + rules: + - if: $CI_PIPELINE_SOURCE == 'merge_request_event' && $CI_MERGE_REQUEST_TARGET_BRANCH_NAME != $CI_DEFAULT_BRANCH + allow_failure: true + - if: $CI_PIPELINE_SOURCE == 'push' && $CI_COMMIT_BRANCH != $CI_DEFAULT_BRANCH + allow_failure: true + - if: $CI_PIPELINE_SOURCE != 'schedule' stage: tier1 script: - date '+%Y%m%d-%H%M%S'; clang-format --version