From f3f5d5c900b8891591eccf2f8e8f5cf3da0907a1 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Thu, 6 Sep 2018 10:29:43 +0200 Subject: [PATCH] platform/trivial: add FIXME comment to use new ethtool API to set link settings --- src/platform/nm-platform-utils.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/platform/nm-platform-utils.c b/src/platform/nm-platform-utils.c index 9459fbc993..216b15478e 100644 --- a/src/platform/nm-platform-utils.c +++ b/src/platform/nm-platform-utils.c @@ -935,6 +935,10 @@ nmp_utils_ethtool_set_link_settings (int ifindex, if (ethtool_call_ifindex (ifindex, &edata) < 0) return FALSE; + /* FIXME: try first new ETHTOOL_GLINKSETTINGS/SLINKSETTINGS API + * https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=3f1ac7a700d039c61d8d8b99f28d605d489a60cf + */ + /* then change the needed ones */ edata.cmd = ETHTOOL_SSET; if (autoneg) {