From f2aa286fa92a8fa6c96d8b7db09e6fb5519bea13 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Wed, 17 Jan 2018 09:18:39 +0100 Subject: [PATCH] libnm: cast guint32 argument to guint in variadic g_object_set() yes, this is not an issue in practice. Variadic arguments are always propagated to at least int/unsigned type. And kernel and glib both require sizeof(guint32) <= sizeof(guint). Hence, this was safe on any supported architecture. Still, let's be explicit about the types. --- libnm-core/nm-connection.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libnm-core/nm-connection.c b/libnm-core/nm-connection.c index 9fd46fdf96..1773841dac 100644 --- a/libnm-core/nm-connection.c +++ b/libnm-core/nm-connection.c @@ -959,7 +959,7 @@ _normalize_infiniband_mtu (NMConnection *self, GHashTable *parameters) max_mtu = 65520; if (max_mtu && nm_setting_infiniband_get_mtu (s_infini) > max_mtu) { - g_object_set (s_infini, NM_SETTING_INFINIBAND_MTU, max_mtu, NULL); + g_object_set (s_infini, NM_SETTING_INFINIBAND_MTU, (guint) max_mtu, NULL); return TRUE; } }