From f27b67cd6583faf4367746d31fd2dff723bf5787 Mon Sep 17 00:00:00 2001 From: Beniamino Galvani Date: Sat, 30 May 2026 22:07:25 +0200 Subject: [PATCH] dhcp/nettools: fix error code for FQDN name-too-long check Use NM_UTILS_ERROR_UNKNOWN explicitly instead of the unrelated variable 'r', which happens to be 0 at this point from a prior unrelated call. Fixes: aa8d5a3e9e06 ('dhcp: support FQDN flags in the nettools backend') --- src/core/dhcp/nm-dhcp-nettools.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/core/dhcp/nm-dhcp-nettools.c b/src/core/dhcp/nm-dhcp-nettools.c index 97f0d33d4d..25a25d19cd 100644 --- a/src/core/dhcp/nm-dhcp-nettools.c +++ b/src/core/dhcp/nm-dhcp-nettools.c @@ -1470,7 +1470,9 @@ ip4_start(NMDhcpClient *client, GError **error) } else { fqdn_len = strlen(client_config->hostname); if (fqdn_len > sizeof(buffer) - 3) { - nm_utils_error_set(error, r, "failed to set DHCP FQDN: name too long"); + nm_utils_error_set_literal(error, + NM_UTILS_ERROR_UNKNOWN, + "failed to set DHCP FQDN: name too long"); return FALSE; } memcpy(buffer + 3, client_config->hostname, fqdn_len);