From f04e554f082496dd4fd2c622c20191a3503e96c7 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Sat, 30 Jan 2016 19:26:43 +0100 Subject: [PATCH] dnsmasq-manager: lazy create debug logging string The logging macros evaluate their arguments only when necessary. This saves creating the message in case debug logging is disabled. --- src/dnsmasq-manager/nm-dnsmasq-manager.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/dnsmasq-manager/nm-dnsmasq-manager.c b/src/dnsmasq-manager/nm-dnsmasq-manager.c index 9299ce898e..c4889c448a 100644 --- a/src/dnsmasq-manager/nm-dnsmasq-manager.c +++ b/src/dnsmasq-manager/nm-dnsmasq-manager.c @@ -335,7 +335,7 @@ nm_dnsmasq_manager_start (NMDnsMasqManager *manager, { NMDnsMasqManagerPrivate *priv; NMCmdLine *dm_cmd; - char *cmd_str; + gs_free char *cmd_str = NULL; g_return_val_if_fail (NM_IS_DNSMASQ_MANAGER (manager), FALSE); if (error) @@ -353,9 +353,8 @@ nm_dnsmasq_manager_start (NMDnsMasqManager *manager, nm_log_info (LOGD_SHARING, "Starting dnsmasq..."); - cmd_str = nm_cmd_line_to_str (dm_cmd); - nm_log_dbg (LOGD_SHARING, "Command line: %s", cmd_str); - g_free (cmd_str); + nm_log_dbg (LOGD_SHARING, "Command line: %s", + (cmd_str = nm_cmd_line_to_str (dm_cmd))); priv->pid = 0; if (!g_spawn_async (NULL, (char **) dm_cmd->array->pdata, NULL,