fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-02-07 04:00:32 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

bluez: fix emitting of REMOVED signal in manager

Browse source 
Ensure, before emitting the REMOVED signal for devices, that the device
was usable before.

Signed-off-by: Thomas Haller <thaller@redhat.com>
This commit is contained in:
Dan Williams 2013-09-25 21:54:55 +02:00 • committed by Thomas Haller
parent 07cc990981
commit ef472259cf
1 changed files with 18 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
src/bluez-manager/nm-bluez-manager.c
View file

@ -56,6 +56,9 @@ enum {
static guint signals[LAST_SIGNAL] = { 0 };
static void device_initialized (NMBluezDevice *device, gboolean success, NMBluezManager *self);
static void device_usable (NMBluezDevice *device, GParamSpec *pspec, NMBluezManager *self);
static void
emit_bdaddr_added (NMBluezManager *self, NMBluezDevice *device)
{
@ -81,6 +84,18 @@ nm_bluez_manager_query_devices (NMBluezManager *self)
}
}
static void
remove_device (NMBluezManager *self, NMBluezDevice *device)
{
if (nm_bluez_device_get_usable (device)) {
g_signal_emit (self, signals[BDADDR_REMOVED], 0,
nm_bluez_device_get_address (device),
nm_bluez_device_get_path (device));
}
g_signal_handlers_disconnect_by_func (device, G_CALLBACK (device_initialized), self);
g_signal_handlers_disconnect_by_func (device, G_CALLBACK (device_usable), self);
}
static void
device_usable (NMBluezDevice *device, GParamSpec *pspec, NMBluezManager *self)
{
@ -139,11 +154,7 @@ device_removed (GDBusProxy *proxy, const gchar *path, NMBluezManager *self)
if (device) {
g_object_ref (device);
g_hash_table_remove (priv->devices, nm_bluez_device_get_path (device));
g_signal_emit (self, signals[BDADDR_REMOVED], 0,
nm_bluez_device_get_address (device),
nm_bluez_device_get_path (device));
remove_device (NM_BLUEZ_MANAGER (self), device);
g_object_unref (device);
}
}
@ -284,9 +295,7 @@ name_owner_changed_cb (NMDBusManager *dbus_mgr,
g_hash_table_iter_init (&iter, priv->devices);
while (g_hash_table_iter_next (&iter, NULL, (gpointer) &device))
g_signal_emit (self, signals[BDADDR_REMOVED], 0,
nm_bluez_device_get_address (device),
nm_bluez_device_get_path (device));
remove_device (self, device);
g_hash_table_remove_all (priv->devices);
}
}
@ -307,9 +316,7 @@ bluez_cleanup (NMBluezManager *self, gboolean do_signal)
if (do_signal) {
g_hash_table_iter_init (&iter, priv->devices);
while (g_hash_table_iter_next (&iter, NULL, (gpointer) &device))
g_signal_emit (self, signals[BDADDR_REMOVED], 0,
nm_bluez_device_get_address (device),
nm_bluez_device_get_path (device));
remove_device (self, device);
}
g_hash_table_remove_all (priv->devices);