From eee2eda4b5ab36f77c452509ed54db0faddccb89 Mon Sep 17 00:00:00 2001 From: Beniamino Galvani Date: Wed, 10 Apr 2019 16:02:31 +0200 Subject: [PATCH] clients: fix assertion when requesting gsm pin secret [root@gsm-r5s4-01 ~]# nmcli connection up id gsm ** libnmc:ERROR:clients/common/nm-secret-agent-simple.c:171:_secret_real_new_plain: assertion failed: ((secret_type == NM_SECRET_AGENT_SECRET_TYPE_SECRET) == nm_setting_get_secret_flags (setting, property, ((void *)0), ((void *)0))) Aborted (core dumped) The pin is a secret property. https://bugzilla.redhat.com/show_bug.cgi?id=1698495 (cherry picked from commit a94ccc9acc47f08943f017a5040abeb05afee183) --- clients/common/nm-secret-agent-simple.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clients/common/nm-secret-agent-simple.c b/clients/common/nm-secret-agent-simple.c index cd3ce2eeea..c4eb794638 100644 --- a/clients/common/nm-secret-agent-simple.c +++ b/clients/common/nm-secret-agent-simple.c @@ -889,7 +889,7 @@ request_secrets_from_ui (RequestData *request) title = _("PIN code required"); msg = g_strdup (_("PIN code is needed for the mobile broadband device")); - secret = _secret_real_new_plain (NM_SECRET_AGENT_SECRET_TYPE_PROPERTY, + secret = _secret_real_new_plain (NM_SECRET_AGENT_SECRET_TYPE_SECRET, _("PIN"), NM_SETTING (s_gsm), NM_SETTING_GSM_PIN);