From ee5030c7bd1e16f0720953e622f0d463ca9d2c5a Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Mon, 26 Jul 2021 18:08:24 +0200 Subject: [PATCH] nm-sudo: fix printf format string in _handle_ping() src/nm-sudo/nm-sudo.c: In function '_handle_ping': src/nm-sudo/nm-sudo.c:92:79: error: format '%ld' expects argument of type 'long int', but argument 5 has type 'gint64' {aka 'long long int'} [-Werror=format=] 92 | msg = g_strdup_printf("pid=%lu, unique-name=%s, nm-name-owner=%s, since=%ld.%03d%s, pong=%s", | ~~^ | | | long int | %lld ...... 96 | running_msec / 1000, | ~~~~~~~~~~~~~~~~~~~ | | | gint64 {aka long long int} Fixes: f137b32d3117 ('sudo: introduce nm-sudo D-Bus service') --- src/nm-sudo/nm-sudo.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/nm-sudo/nm-sudo.c b/src/nm-sudo/nm-sudo.c index 7dd22b1c69..5e1d91b8ab 100644 --- a/src/nm-sudo/nm-sudo.c +++ b/src/nm-sudo/nm-sudo.c @@ -89,11 +89,12 @@ _handle_ping(GlobalData *gl, GDBusMethodInvocation *invocation, const char *arg) running_msec = nm_utils_clock_gettime_msec(CLOCK_BOOTTIME) - gl->start_timestamp_msec; - msg = g_strdup_printf("pid=%lu, unique-name=%s, nm-name-owner=%s, since=%ld.%03d%s, pong=%s", + msg = g_strdup_printf("pid=%lu, unique-name=%s, nm-name-owner=%s, since=%" G_GINT64_FORMAT + ".%03d%s, pong=%s", (unsigned long) getpid(), g_dbus_connection_get_unique_name(gl->dbus_connection), gl->name_owner ?: "(none)", - running_msec / 1000, + (gint64) (running_msec / 1000), (int) (running_msec % 1000), gl->no_auth_for_testing ? ", no-auth-for-testing" : "", arg);