libnm/vpn-editor-plugin: add a comment on a design blunder

VPN plugin factory can never fail, it always returns an object, much
like g_object_new(). If the (GUI) editor is unavailable, it might be
okay for some use cases, notably import()/export(). In such case, the
absence of GUI editor is indicated via capability flags.
This commit is contained in:
Lubomir Rintel 2024-09-11 15:35:50 +02:00
parent a1a9a6509e
commit ecf1e8716c

View file

@ -299,6 +299,9 @@ _nm_vpn_editor_plugin_load(const char *plugin_name,
return NULL;
}
/* Note that factory() shouldn't be returning errors or failing.
* We can't change its prototype as it would consistute an ABI break,
* however it returning a failure would indicate a bug in the plugin. */
editor_plugin = factory(&factory_error);
if (loaded_before) {