From eb642fecdf4f57d4e8673065063cf429e986014a Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Mon, 9 Dec 2019 09:48:02 +0100 Subject: [PATCH] settings: fix use after free in keyfile's load_connections() Fixes: d35d3c468a30 ('settings: rework tracking settings connections and settings plugins') --- src/settings/plugins/keyfile/nms-keyfile-plugin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/settings/plugins/keyfile/nms-keyfile-plugin.c b/src/settings/plugins/keyfile/nms-keyfile-plugin.c index 7129d6f316..fdb88d2a6d 100644 --- a/src/settings/plugins/keyfile/nms-keyfile-plugin.c +++ b/src/settings/plugins/keyfile/nms-keyfile-plugin.c @@ -355,7 +355,7 @@ _load_file (NMSKeyfilePlugin *self, &local); if (!connection) { if (error) - g_propagate_error (error, local); + g_propagate_error (error, g_steal_pointer (&local)); else _LOGW ("load: \"%s\": failed to load connection: %s", full_filename, local->message); return NULL;