From e9ccc2da1926d969ffc95c469b8303877562302a Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Sat, 24 Aug 2019 13:44:14 +0200 Subject: [PATCH] ifupdown: fix crash loading ifupdown settings with empty entries like bridge-ports and mappings Fixes: d35d3c468a30 ('settings: rework tracking settings connections and settings plugins') https://gitlab.freedesktop.org/NetworkManager/NetworkManager/issues/235 --- src/settings/plugins/ifupdown/nms-ifupdown-plugin.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/settings/plugins/ifupdown/nms-ifupdown-plugin.c b/src/settings/plugins/ifupdown/nms-ifupdown-plugin.c index 475ecbb6d9..e663ab8a67 100644 --- a/src/settings/plugins/ifupdown/nms-ifupdown-plugin.c +++ b/src/settings/plugins/ifupdown/nms-ifupdown-plugin.c @@ -89,6 +89,8 @@ static GHashTable *load_eni_ifaces (NMSIfupdownPlugin *self); static void _storage_data_destroy (StorageData *sd) { + if (!sd) + return; nm_g_object_unref (sd->connection); nm_g_object_unref (sd->storage); g_slice_free (StorageData, sd);