keyfile: drop with_extension argument from _internal_write_connection()

For non-test code, we always passed TRUE.

For test code, setting with_extension is fine too, so drop the
argument.
This commit is contained in:
Thomas Haller 2018-10-19 15:27:11 +02:00
parent c4a9f44aff
commit e93d8cdb74

View file

@ -173,7 +173,6 @@ static gboolean
_internal_write_connection (NMConnection *connection,
const char *keyfile_dir,
const char *profile_dir,
gboolean with_extension,
uid_t owner_uid,
pid_t owner_grp,
const char *existing_path,
@ -230,7 +229,7 @@ _internal_write_connection (NMConnection *connection,
if (existing_path != NULL && !rename) {
path = g_strdup (existing_path);
} else {
char *filename_escaped = nm_keyfile_utils_create_filename (id, with_extension);
char *filename_escaped = nm_keyfile_utils_create_filename (id, TRUE);
path = g_build_filename (keyfile_dir, filename_escaped, NULL);
g_free (filename_escaped);
@ -256,7 +255,7 @@ _internal_write_connection (NMConnection *connection,
else
filename = g_strdup_printf ("%s-%s-%u", id, nm_connection_get_uuid (connection), i);
filename_escaped = nm_keyfile_utils_create_filename (filename, with_extension);
filename_escaped = nm_keyfile_utils_create_filename (filename, TRUE);
g_free (path);
path = g_strdup_printf ("%s/%s", keyfile_dir, filename_escaped);
@ -361,7 +360,6 @@ nms_keyfile_writer_connection (NMConnection *connection,
return _internal_write_connection (connection,
keyfile_dir,
nms_keyfile_utils_get_path (),
TRUE,
0,
0,
existing_path,
@ -385,7 +383,6 @@ nms_keyfile_writer_test_connection (NMConnection *connection,
return _internal_write_connection (connection,
keyfile_dir,
keyfile_dir,
FALSE,
owner_uid,
owner_grp,
NULL,