From e80346fff7b9262ea9abd8a2a8e976e7b41092de Mon Sep 17 00:00:00 2001 From: Lubomir Rintel Date: Thu, 21 Jan 2016 16:56:19 +0100 Subject: [PATCH] utils: fix error open() handling CID 59376 (#2-1 of 2): Argument cannot be negative (NEGATIVE_RETURNS) negative_returns: urandom is passed to a parameter that cannot be negative. --- src/NetworkManagerUtils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/NetworkManagerUtils.c b/src/NetworkManagerUtils.c index fb680d96d5..76116aca80 100644 --- a/src/NetworkManagerUtils.c +++ b/src/NetworkManagerUtils.c @@ -3416,7 +3416,7 @@ nm_utils_ipv6_addr_set_stable_privacy (struct in6_addr *addr, int urandom = open ("/dev/urandom", O_RDONLY); mode_t key_mask; - if (!urandom) { + if (urandom == -1) { g_set_error (error, NM_UTILS_ERROR, NM_UTILS_ERROR_UNKNOWN, "Can't open /dev/urandom: %s", strerror (errno)); return FALSE;