From e7a211caa144723786ccad7733fb36e8799c897b Mon Sep 17 00:00:00 2001
From: Beniamino Galvani <bgalvani@redhat.com>
Date: Sat, 30 May 2026 18:59:17 +0200
Subject: [PATCH] device: fix ref leak in controller_release_port when detach
 completes synchronously

When detach_port() returns a value other than NM_TERNARY_DEFAULT,
the g_object_ref(port) passed as user_data for the async callback
is never released.

Fixes: 07dc237e5ccb ('device: wait port detach before leaving the DEACTIVATING state')
---
 src/core/devices/nm-device.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/core/devices/nm-device.c b/src/core/devices/nm-device.c
index 6e9b04b34f..e882970479 100644
--- a/src/core/devices/nm-device.c
+++ b/src/core/devices/nm-device.c
@@ -7278,6 +7278,8 @@ nm_device_controller_release_port(NMDevice           *self,
         if (ret == NM_TERNARY_DEFAULT) {
             port_priv->port_detach_count++;
             port_priv->port_detach_reason = reason;
+        } else {
+            g_object_unref(port);
         }
     }