From e68e5c0a4c36ab6fe7cf4793f77ca741179690ce Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Thu, 26 Nov 2020 18:15:42 +0100 Subject: [PATCH] contrib/rpm: on rhel-9 let a test failure or compiler warning fail the build We always run the unit tests during package build and also enable all compiler warnings. However, by default we used to ignore failures. That is, because rebuilding a package on another, future distro led to frequent, annoying build failures. Especially compiler warnings appear easily when using a different compiler version. The default mostly matters here when you want to build the package in brew/koji, where you don't have a possibility to explicitly select the build option. Note that rpmdiff detects failures in the build log, and thus we usually would not miss failures for builds we add to errata. Also, all our CI tests build packages with a manner where they would not allow a failure of the unit tests. So, we run these unit tests frequently and in a manner where we notice a failure. For rhel-9 builds, change the default here and let test failures and compiler warnings be fatal to the build. --- contrib/fedora/rpm/NetworkManager.spec | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/contrib/fedora/rpm/NetworkManager.spec b/contrib/fedora/rpm/NetworkManager.spec index 343e291998..8c0caebffa 100644 --- a/contrib/fedora/rpm/NetworkManager.spec +++ b/contrib/fedora/rpm/NetworkManager.spec @@ -58,7 +58,11 @@ %bcond_without nm_cloud_setup %bcond_without regen_docs %bcond_with debug +%if 0%{?rhel} >= 9 +%bcond_without test +%else %bcond_with test +%endif %if 0%{?fedora} >= 33 || 0%{?rhel} >= 9 %bcond_without lto %else