From e4941696befcf758fda3b9328dce8f2d19132647 Mon Sep 17 00:00:00 2001 From: Tony Espy Date: Fri, 5 Mar 2021 15:09:30 +0530 Subject: [PATCH] wwan/modem: do not mark connection as failed when connection drops If the modem is connected, and registrations drops, and then is restored, the connection isn't re-activated. The fix was simply to change modem_state_cb to not return after setting the state to failed, which allows nm_device_queue_recheck_available to be called, which queues a state transition to UNAVAILABLE. --- src/core/devices/wwan/nm-device-modem.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/core/devices/wwan/nm-device-modem.c b/src/core/devices/wwan/nm-device-modem.c index 87d4023817..405ced64a1 100644 --- a/src/core/devices/wwan/nm-device-modem.c +++ b/src/core/devices/wwan/nm-device-modem.c @@ -357,7 +357,6 @@ modem_state_cb(NMModem *modem, int new_state_i, int old_state_i, gpointer user_d nm_device_state_changed(device, NM_DEVICE_STATE_FAILED, NM_DEVICE_STATE_REASON_MODEM_NO_CARRIER); - return; } if (new_state > NM_MODEM_STATE_LOCKED && old_state == NM_MODEM_STATE_LOCKED) {