fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-05-04 21:08:04 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

glib-aux: pass string length to nm_uuid_generate_from_string() in nm_uuid_is_valid_nm()

Browse source 
No need to recompute the length. We have it already.
Also no need to NUL terminate the string.
This commit is contained in:
Thomas Haller 2022-06-24 10:17:14 +02:00
parent 2dd76e6b98
commit e3a0157141
No known key found for this signature in database
GPG key ID: 29C2366E4DFC5728
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/libnm-glib-aux/nm-uuid.c
View file

@ -235,24 +235,23 @@ nm_uuid_is_valid_nm(const char *str,
* are made lower case first. */
NM_SET_OUT(out_normalized, TRUE);
if (out_normalized_str) {
char str_lower[40 + 1];
char str_lower[40];
int i;
nm_assert(strlen(str) < G_N_ELEMENTS(str_lower));
nm_assert(strlen(str) <= G_N_ELEMENTS(str_lower));
/* normalize first to lower-case. */
for (i = 0; str[i]; i++) {
nm_assert(i < G_N_ELEMENTS(str_lower));
str_lower[i] = g_ascii_tolower(str[i]);
}
nm_assert(i < G_N_ELEMENTS(str_lower));
str_lower[i] = '\0';
nm_assert(i <= G_N_ELEMENTS(str_lower));
/* The namespace UUID is chosen randomly. */
nm_uuid_generate_from_string(
&uuid,
str_lower,
-1,
i,
NM_UUID_TYPE_VERSION5,
&NM_UUID_INIT(4e, 72, f7, 09, ca, 95, 44, 05, 90, 53, 1f, 43, 29, 4a, 61, 8c));
nm_uuid_unparse(&uuid, out_normalized_str);