From e3722827bf7c9591050eb35c48d65b81b4a64aee Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Wed, 3 Aug 2022 12:10:41 +0200 Subject: [PATCH] glib-aux: add assertions to nm_utils_fd_wait_for_event() (cherry picked from commit e80fc43f2a12db7feb7b7ad0807db3a0cf244bae) --- src/libnm-glib-aux/nm-shared-utils.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/libnm-glib-aux/nm-shared-utils.c b/src/libnm-glib-aux/nm-shared-utils.c index e6ee04d7cd..f770b96dc9 100644 --- a/src/libnm-glib-aux/nm-shared-utils.c +++ b/src/libnm-glib-aux/nm-shared-utils.c @@ -3347,6 +3347,8 @@ nm_utils_fd_wait_for_event(int fd, int event, gint64 timeout_nsec) struct timespec ts, *pts; int r; + nm_assert(fd >= 0); + if (timeout_nsec < 0) pts = NULL; else { @@ -3360,6 +3362,13 @@ nm_utils_fd_wait_for_event(int fd, int event, gint64 timeout_nsec) return -NM_ERRNO_NATIVE(errno); if (r == 0) return 0; + + nm_assert(r == 1); + nm_assert(pollfd.revents > 0); + + if (pollfd.revents & POLLNVAL) + return nm_assert_unreachable_val(-EBADF); + return pollfd.revents; }