From e2ac542dbcc87eb5324e26a489b8d161e107695d Mon Sep 17 00:00:00 2001 From: Lubomir Rintel Date: Mon, 31 Mar 2025 18:08:56 +0200 Subject: [PATCH] nmcli/connections: fix build with libedit MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This has always been broken (libedit-0:3.1-17.20160618cvs.fc26 is too old to work and libedit-0:3.1-20.20170329cvs.fc27.x86_64 has this type mismatch), but new GCC complains (14, 15). ../src/nmcli/connections.c: In function ‘nmcli_editor_tab_completion’: ../src/nmcli/connections.c:6862:64: error: assignment to ‘void (*)(char **, int, int)’ from incompatible pointer type ‘void (*)(void)’ [-Wincompatible-pointer-types] 6862 | rl_completion_display_matches_hook = uuid_display_hook; | ^ ../src/nmcli/connections.c:6909:60: error: assignment to ‘void (*)(char **, int, int)’ from incompatible pointer type ‘void (*)(void)’ [-Wincompatible-pointer-types] 6909 | rl_completion_display_matches_hook = uuid_display_hook; | ^ --- src/nmcli/connections.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/nmcli/connections.c b/src/nmcli/connections.c index 505be6d157..185e7b19c5 100644 --- a/src/nmcli/connections.c +++ b/src/nmcli/connections.c @@ -6073,7 +6073,7 @@ finish: /* Functions for readline TAB completion in editor */ #if HAVE_EDITLINE_READLINE -#define uuid_display_hook ((void (*)(void)) NULL) +#define uuid_display_hook ((void (*)(char **, int, int)) NULL) #else static void uuid_display_hook(char **array, int len, int max_len)