From de9848aa66d2ef97a53ad04c537df4859baea243 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Fri, 17 Apr 2015 14:09:55 +0200 Subject: [PATCH] core: optimize nm_match_spec_s390_subchannels() to return early No need to parse the subchannels if the spec list is empty. This isn't actually an issue, because nm_match_spec_s390_subchannels() was never called with empty spec list. --- src/NetworkManagerUtils.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/NetworkManagerUtils.c b/src/NetworkManagerUtils.c index 2a88c946a4..82d695c4d6 100644 --- a/src/NetworkManagerUtils.c +++ b/src/NetworkManagerUtils.c @@ -1108,6 +1108,9 @@ nm_match_spec_s390_subchannels (const GSList *specs, const char *subchannels) g_return_val_if_fail (subchannels != NULL, NM_MATCH_SPEC_NO_MATCH); + if (!specs) + return NM_MATCH_SPEC_NO_MATCH; + if (!parse_subchannels (subchannels, &a, &b, &c)) return NM_MATCH_SPEC_NO_MATCH;