From ddbb63afeb68b213fa530baf0863593a42fd9688 Mon Sep 17 00:00:00 2001 From: Francesco Giudici Date: Mon, 3 Apr 2017 12:41:55 +0200 Subject: [PATCH] nmcli: fix 'nmcli con export' parameters check get_connection() will already move forward arguments (argc/argv): remove extra argv++/argc-- Example: "nmcli con export " now, extra_arg is detected, printing error: "Error: unknown extra argument: 'extra_arg'." (cherry picked from commit 512ed904c61418332633c7ed3da03777bdc269a1) --- clients/cli/connections.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/clients/cli/connections.c b/clients/cli/connections.c index 3558c88c8b..46b73257f4 100644 --- a/clients/cli/connections.c +++ b/clients/cli/connections.c @@ -8756,11 +8756,7 @@ do_connection_export (NmCli *nmc, int argc, char **argv) if (nmc->complete) return nmc->return_value; - if (argc) { - out_name = *argv; - argc--; - argv++; - } + out_name = *argv; if (next_arg (nmc->ask ? NULL : nmc, argc_ptr, argv_ptr, NULL) == 0) { g_string_printf (nmc->return_text, _("Error: unknown extra argument: '%s'."), *argv);