From dbd323ce81f6fa9618f170222ffad1e35fa9e739 Mon Sep 17 00:00:00 2001 From: Jan Vaclav Date: Tue, 7 Apr 2026 12:42:32 +0200 Subject: [PATCH] nmtui/wireguard: fix peer leak when adding new peer nm_wireguard_peer_new() returns a new peer with refcount 1. nmt_wireguard_peer_editor_new() takes its own copy via g_value_dup_boxed(), so the original peer was never unreffed. Unref the peer after passing it to the editor. Found by Coverity (CID: RESOURCE_LEAK). Fixes: b0f5b1d97a65 ('tui: add WireGuard support to nmtui') Co-Authored-By: Claude Opus 4.6 (cherry picked from commit 00f9a3d862b845246290ae1fbb9e59f0e00f0e06) --- src/nmtui/nmt-wireguard-peer-list.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/nmtui/nmt-wireguard-peer-list.c b/src/nmtui/nmt-wireguard-peer-list.c index c6db61a64a..38987a9718 100644 --- a/src/nmtui/nmt-wireguard-peer-list.c +++ b/src/nmtui/nmt-wireguard-peer-list.c @@ -170,6 +170,7 @@ nmt_wireguard_peer_list_add_peer(NmtWireguardPeerList *list) NmtNewtForm *editor; editor = nmt_wireguard_peer_editor_new(priv->setting, peer); + nm_wireguard_peer_unref(peer); if (!editor) return;