fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-01-09 14:40:21 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

ifcfg-rh: fail nms_ifcfg_rh_writer_write_connection() without filename/dir

Browse source 
No actual caller should use the API without providing either a filename
or the directory name. I don't think this can actually happen, hence
fail and assert in that case.
This commit is contained in:
Thomas Haller 2021-08-24 13:43:02 +02:00
parent 1fa105eaef
commit db13b93563
No known key found for this signature in database
GPG key ID: 29C2366E4DFC5728
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/core/settings/plugins/ifcfg-rh/nms-ifcfg-rh-writer.c
View file

@ -3279,8 +3279,13 @@ do_write_construct(NMConnection * connection,
return FALSE;
}
ifcfg_name = ifcfg_name_free;
} else
ifcfg_name = "/tmp/ifcfg-dummy";
} else {
g_set_error(error,
NM_SETTINGS_ERROR,
NM_SETTINGS_ERROR_FAILED,
"No file name given for storing profile to ifcfg-rh");
g_return_val_if_reached(FALSE);
}
ifcfg = svCreateFile(ifcfg_name);