From da312e62207476624f21efe7be75bcc13e7397b9 Mon Sep 17 00:00:00 2001 From: Lubomir Rintel Date: Tue, 25 Jun 2019 10:13:49 +0200 Subject: [PATCH] contrib/checkpatch: be a bit stricter about whitespace In continations (that use spaces for alignment), don't allow the number of leading tabs to change. Previously only removal of tabs was disallowed, but addition doesn't make sense either, as only spaces should be used for further alignemnt. This catches situations like this: |<-tab->all_work_and_no_play (makes, |<-tab-> jack, |<-tab-><-tab-> a dull boy); --- contrib/scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/scripts/checkpatch.pl b/contrib/scripts/checkpatch.pl index 65996eca7f..78ac3cb305 100755 --- a/contrib/scripts/checkpatch.pl +++ b/contrib/scripts/checkpatch.pl @@ -204,7 +204,7 @@ if (defined $indent) { complain ("Bad indentation") if $this_indent =~ /^$indent\t+ +/ or (defined $tabs_before_spaces and defined $this_tabs_before_spaces - and $this_tabs_before_spaces < $tabs_before_spaces); + and $this_tabs_before_spaces != $tabs_before_spaces); } $indent = $this_indent;