fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-03-02 19:00:29 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

firewall: fix adding duplicate iptables rules for shared mode

Browse source 
nm_act_request_set_shared() already calls nm_utils_share_rules_apply().
Calling it twice, is pretty bad because during deactivate we will only
remove one of each duplicate rule.

Fixes: 701654b930 ('core: refactor tracking of shared-rules to use NMUtilsShareRules')
(cherry picked from commit 60744889e2)
This commit is contained in:
Thomas Haller 2021-05-04 22:58:13 +02:00
parent e8de0433c2
commit d9bcba347b
No known key found for this signature in database
GPG key ID: 29C2366E4DFC5728
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/core/devices/nm-device.c
View file

@ -11678,8 +11678,6 @@ start_sharing(NMDevice *self, NMIP4Config *config, GError **error)
nm_utils_share_rules_add_all_rules(share_rules, ip_iface, ip4_addr->address, ip4_addr->plen);
nm_utils_share_rules_apply(share_rules, TRUE);
nm_act_request_set_shared(req, share_rules);
conn = nm_act_request_get_applied_connection(req);