From 6c86f68ac44b5301f844c676e7a4f47b3a8f7422 Mon Sep 17 00:00:00 2001 From: Beniamino Galvani Date: Mon, 7 Oct 2019 15:53:30 +0200 Subject: [PATCH 1/6] device: remove useless doc comment D-Bus properties are already documented in the introspection xml files. --- src/devices/nm-device.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/devices/nm-device.c b/src/devices/nm-device.c index e7291f0b54..9fbba30ac6 100644 --- a/src/devices/nm-device.c +++ b/src/devices/nm-device.c @@ -17580,14 +17580,6 @@ nm_device_class_init (NMDeviceClass *klass) FALSE, G_PARAM_READABLE | G_PARAM_STATIC_STRINGS); - - /** - * NMDevice:metered: - * - * Whether the connection is metered. - * - * Since: 1.2 - **/ obj_properties[PROP_METERED] = g_param_spec_uint (NM_DEVICE_METERED, "", "", 0, G_MAXUINT32, NM_METERED_UNKNOWN, From 1b90ad41bba08726136b062e61bb59303a9137fa Mon Sep 17 00:00:00 2001 From: Beniamino Galvani Date: Thu, 10 Oct 2019 09:23:22 +0200 Subject: [PATCH 2/6] core: export interface flags of devices Add a new read-only "InterfaceFlags" property to the Device interface to export via D-Bus kernel flags and possibly other NM specific flags. At the moment IFF_UP and IFF_LOWERUP are implemented. --- .../org.freedesktop.NetworkManager.Device.xml | 11 ++++++ libnm-core/nm-dbus-interface.h | 19 +++++++++++ libnm/libnm.ver | 1 + src/devices/nm-device.c | 34 +++++++++++++++++++ src/devices/nm-device.h | 1 + 5 files changed, 66 insertions(+) diff --git a/introspection/org.freedesktop.NetworkManager.Device.xml b/introspection/org.freedesktop.NetworkManager.Device.xml index 65c2a2c097..ca9dd8d758 100644 --- a/introspection/org.freedesktop.NetworkManager.Device.xml +++ b/introspection/org.freedesktop.NetworkManager.Device.xml @@ -278,6 +278,17 @@ --> + + + diff --git a/introspection/org.freedesktop.NetworkManager.Device.Bond.xml b/introspection/org.freedesktop.NetworkManager.Device.Bond.xml index e3b5574e8c..30421a5450 100644 --- a/introspection/org.freedesktop.NetworkManager.Device.Bond.xml +++ b/introspection/org.freedesktop.NetworkManager.Device.Bond.xml @@ -19,6 +19,9 @@ Indicates whether the physical carrier is found (e.g. whether a cable is plugged in or not). + + DEPRECATED: check for the "lower-up" flag in the "InterfaceFlags" + property on the "org.freedesktop.NetworkManager.Device" interface. --> diff --git a/introspection/org.freedesktop.NetworkManager.Device.Bridge.xml b/introspection/org.freedesktop.NetworkManager.Device.Bridge.xml index 7f2605699d..011805acb0 100644 --- a/introspection/org.freedesktop.NetworkManager.Device.Bridge.xml +++ b/introspection/org.freedesktop.NetworkManager.Device.Bridge.xml @@ -19,6 +19,9 @@ Indicates whether the physical carrier is found (e.g. whether a cable is plugged in or not). + + DEPRECATED: check for the "carrier" flag in the "InterfaceFlags" + property on the "org.freedesktop.NetworkManager.Device" interface. --> diff --git a/introspection/org.freedesktop.NetworkManager.Device.Infiniband.xml b/introspection/org.freedesktop.NetworkManager.Device.Infiniband.xml index 26e2694bef..cc03b74b8d 100644 --- a/introspection/org.freedesktop.NetworkManager.Device.Infiniband.xml +++ b/introspection/org.freedesktop.NetworkManager.Device.Infiniband.xml @@ -19,6 +19,9 @@ Indicates whether the physical carrier is found (e.g. whether a cable is plugged in or not). + + DEPRECATED: check for the "lower-up" flag in the "InterfaceFlags" + property on the "org.freedesktop.NetworkManager.Device" interface. --> diff --git a/introspection/org.freedesktop.NetworkManager.Device.Team.xml b/introspection/org.freedesktop.NetworkManager.Device.Team.xml index 2318dd6fcf..a0caa3992a 100644 --- a/introspection/org.freedesktop.NetworkManager.Device.Team.xml +++ b/introspection/org.freedesktop.NetworkManager.Device.Team.xml @@ -19,6 +19,9 @@ Indicates whether the physical carrier is found (e.g. whether a cable is plugged in or not). + + DEPRECATED: check for the "lower-up" flag in the "InterfaceFlags" + property on the "org.freedesktop.NetworkManager.Device" interface. --> diff --git a/introspection/org.freedesktop.NetworkManager.Device.Vlan.xml b/introspection/org.freedesktop.NetworkManager.Device.Vlan.xml index 75d6ba430b..1bc83fce78 100644 --- a/introspection/org.freedesktop.NetworkManager.Device.Vlan.xml +++ b/introspection/org.freedesktop.NetworkManager.Device.Vlan.xml @@ -19,6 +19,9 @@ Indicates whether the physical carrier is found (e.g. whether a cable is plugged in or not). + + DEPRECATED: check for the "carrier" flag in the "InterfaceFlags" + property on the "org.freedesktop.NetworkManager.Device" interface. --> diff --git a/introspection/org.freedesktop.NetworkManager.Device.Wired.xml b/introspection/org.freedesktop.NetworkManager.Device.Wired.xml index ae709031ba..f62c3f0c3b 100644 --- a/introspection/org.freedesktop.NetworkManager.Device.Wired.xml +++ b/introspection/org.freedesktop.NetworkManager.Device.Wired.xml @@ -41,6 +41,9 @@ Indicates whether the physical carrier is found (e.g. whether a cable is plugged in or not). + + DEPRECATED: check for the "carrier" flag in the "InterfaceFlags" + property on the "org.freedesktop.NetworkManager.Device" interface. -->