From d8d0b37adcb4455e390b495dede218fdc60c3a3c Mon Sep 17 00:00:00 2001 From: Dan Williams Date: Mon, 21 Jul 2014 13:04:08 -0500 Subject: [PATCH] platform: fix uninitialized variable usage after fdf78b3d 'address' was not initialized, so using address.ifindex was not going to work. ==6777== Conditional jump or move depends on uninitialised value(s) ==6777== at 0x44A6DB: check_cache_items (nm-linux-platform.c:1510) ==6777== by 0x44AA4F: announce_object (nm-linux-platform.c:1586) ==6777== by 0x44A59A: refresh_object (nm-linux-platform.c:1666) ==6777== by 0x44A676: check_cache_items (nm-linux-platform.c:1517) ==6777== by 0x44A812: announce_object (nm-linux-platform.c:1566) ==6777== by 0x44D957: handle_udev_event (nm-linux-platform.c:3964) ==6777== by 0x3BAFC125A7: g_closure_invoke (gclosure.c:777) ==6777== by 0x3BAFC2465C: signal_emit_unlocked_R (gsignal.c:3586) ==6777== by 0x3BAFC2C3E1: g_signal_emit_valist (gsignal.c:3330) ==6777== by 0x3BAFC2C69E: g_signal_emit (gsignal.c:3386) ==6777== by 0x3D93A03BE3: ??? (in /usr/lib64/libgudev-1.0.so.0.1.3) ==6777== by 0x3BAF8521D5: g_main_context_dispatch (gmain.c:3066) --- src/platform/nm-linux-platform.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/platform/nm-linux-platform.c b/src/platform/nm-linux-platform.c index ec0bd7521a..6c8d3fd77d 100644 --- a/src/platform/nm-linux-platform.c +++ b/src/platform/nm-linux-platform.c @@ -1583,7 +1583,9 @@ announce_object (NMPlatform *platform, const struct nl_object *object, NMPlatfor */ switch (change_type) { case NM_PLATFORM_SIGNAL_REMOVED: - check_cache_items (platform, priv->route_cache, address.ifindex); + check_cache_items (platform, + priv->route_cache, + rtnl_addr_get_ifindex ((struct rtnl_addr *) object)); break; default: break;