fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-05-07 14:18:12 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

tui: width and height parameters was swapped, but they are ignored anyway

Browse source 
Coverity: Defect type: SWAPPED_ARGUMENTS
clients/tui/newt/nmt-newt-section.c:328: swapped_arguments: The positions of arguments in the call to "nmt_newt_widget_size_request" do not match the ordering of the parameters: * "&border_height" is passed to "width" * "&border_width" is passed to "height"
This commit is contained in:
Jiří Klimeš 2014-12-04 16:39:45 +01:00
parent f93128194e
commit d80bb52872
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
clients/tui/newt/nmt-newt-section.c
View file

@ -260,12 +260,12 @@ nmt_newt_section_size_request (NmtNewtWidget *widget,
int *height) int *height)
{ {
NmtNewtSectionPrivate *priv = NMT_NEWT_SECTION_GET_PRIVATE (widget); NmtNewtSectionPrivate *priv = NMT_NEWT_SECTION_GET_PRIVATE (widget);
int border_width, border_height; int w_ignore, h_ignore;
g_return_if_fail (priv->header != NULL && priv->body != NULL); g_return_if_fail (priv->header != NULL && priv->body != NULL);
if (priv->show_border) if (priv->show_border)
nmt_newt_widget_size_request (priv->border_grid, &border_width, &border_height); nmt_newt_widget_size_request (priv->border_grid, &w_ignore, &h_ignore);
nmt_newt_widget_size_request (priv->header, &priv->hwidth_req, &priv->hheight_req); nmt_newt_widget_size_request (priv->header, &priv->hwidth_req, &priv->hheight_req);
nmt_newt_widget_size_request (priv->body, &priv->bwidth_req, &priv->bheight_req); nmt_newt_widget_size_request (priv->body, &priv->bwidth_req, &priv->bheight_req);
@ -322,10 +322,10 @@ nmt_newt_section_size_allocate (NmtNewtWidget *widget,
NmtNewtSectionPrivate *priv = NMT_NEWT_SECTION_GET_PRIVATE (widget); NmtNewtSectionPrivate *priv = NMT_NEWT_SECTION_GET_PRIVATE (widget);
if (priv->show_border) { if (priv->show_border) {
int border_height, border_width; int w_ignore, h_ignore;
adjust_border_for_allocation (priv, height); adjust_border_for_allocation (priv, height);
nmt_newt_widget_size_request (priv->border_grid, &border_height, &border_width); nmt_newt_widget_size_request (priv->border_grid, &w_ignore, &h_ignore);
nmt_newt_widget_size_allocate (priv->border_grid, x, y, 1, height); nmt_newt_widget_size_allocate (priv->border_grid, x, y, 1, height);
nmt_newt_widget_size_allocate (priv->header, x + 2, y, width, priv->hheight_req); nmt_newt_widget_size_allocate (priv->header, x + 2, y, width, priv->hheight_req);
} else } else