From d7c70dd9ecdbc049dcee15d6dd3e2e19486bc784 Mon Sep 17 00:00:00 2001 From: Lubomir Rintel Date: Mon, 12 Feb 2018 18:48:30 +0000 Subject: [PATCH] platform/netns: don't try to overlay ro /sys with a rw one Linux 4.15 won't allow us. No problem. --- src/platform/nmp-netns.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/platform/nmp-netns.c b/src/platform/nmp-netns.c index e31c881d66..f1092fe93b 100644 --- a/src/platform/nmp-netns.c +++ b/src/platform/nmp-netns.c @@ -475,6 +475,7 @@ nmp_netns_new (void) NMPNetns *self; int errsv; GError *error = NULL; + unsigned long mountflags = 0; _stack_ensure_init (); @@ -503,7 +504,10 @@ nmp_netns_new (void) goto err_out; } - if (mount ("sysfs", "/sys", "sysfs", 0, NULL) != 0) { + if (access ("/sys", W_OK) == -1) + mountflags = MS_RDONLY; + + if (mount ("sysfs", "/sys", "sysfs", mountflags, NULL) != 0) { errsv = errno; _LOGE (NULL, "failed mount /sys: %s", g_strerror (errsv)); goto err_out;