fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-05-06 02:18:00 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

platform/netlink: assert for valid string in nla_get_string()

Browse source
This commit is contained in:
Thomas Haller 2023-02-17 10:11:46 +01:00
parent 90cc458d31
commit d73a5d692b
No known key found for this signature in database
GPG key ID: 29C2366E4DFC5728
1 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/libnm-platform/nm-netlink.h
View file

@ -238,7 +238,18 @@ nla_get_be64(const struct nlattr *nla)
static inline char * static inline char *
nla_get_string(const struct nlattr *nla) nla_get_string(const struct nlattr *nla)
{ {
return nla_data(nla); char *s;
/* nla_get_string() requires that nla contains a NUL terminated string.
* It cannot return NULL. Only use it with attributes that validate as NLA_STRING. */
nm_assert(nla_len(nla) > 0);
s = nla_data(nla);
nm_assert(memchr(s, 0, nla_len(nla)));
return s;
} }
size_t nla_strlcpy(char *dst, const struct nlattr *nla, size_t dstsize); size_t nla_strlcpy(char *dst, const struct nlattr *nla, size_t dstsize);