diff --git a/src/nm-netlink-compat.c b/src/nm-netlink-compat.c index 974121ad1f..e30ec37a63 100644 --- a/src/nm-netlink-compat.c +++ b/src/nm-netlink-compat.c @@ -121,7 +121,7 @@ rtnl_link_vlan_get_id (struct rtnl_link *l) if ((if_name = rtnl_link_get_name (l)) == NULL) return -1; - strcpy (if_request.device1, if_name); + g_strlcpy (if_request.device1, if_name, sizeof (if_request.device1)); if ((fd = socket (AF_INET, SOCK_STREAM, 0)) < 0) { nm_log_err (LOGD_DEVICE, "couldn't open control socket."); @@ -158,7 +158,7 @@ rtnl_link_vlan_set_flags (struct rtnl_link *l, unsigned int flags) } memset (&if_request, 0, sizeof (struct vlan_ioctl_args)); - strcpy (if_request.device1, if_name); + g_strlcpy (if_request.device1, if_name, sizeof (if_request.device1)); if_request.cmd = SET_VLAN_FLAG_CMD; if_request.u.flag = flags; @@ -190,7 +190,7 @@ rtnl_link_vlan_set_ingress_map (struct rtnl_link *l, int from, uint32_t to) } memset (&if_request, 0, sizeof (struct vlan_ioctl_args)); - strcpy (if_request.device1, if_name); + g_strlcpy (if_request.device1, if_name, sizeof (if_request.device1)); if_request.cmd = SET_VLAN_INGRESS_PRIORITY_CMD; if_request.u.skb_priority = from; if_request.vlan_qos = to; @@ -223,7 +223,7 @@ rtnl_link_vlan_set_egress_map (struct rtnl_link *l, int from, uint32_t to) } memset (&if_request, 0, sizeof (struct vlan_ioctl_args)); - strcpy (if_request.device1, if_name); + g_strlcpy (if_request.device1, if_name, sizeof (if_request.device1)); if_request.cmd = SET_VLAN_EGRESS_PRIORITY_CMD; if_request.u.skb_priority = from; if_request.vlan_qos = to; diff --git a/src/nm-system.c b/src/nm-system.c index 4cebb13b9a..5156eee315 100644 --- a/src/nm-system.c +++ b/src/nm-system.c @@ -1743,7 +1743,7 @@ nm_system_iface_compat_add_vlan_device (const char *master, int vid) } memset (&if_request, 0, sizeof (struct vlan_ioctl_args)); - strcpy (if_request.device1, master); + g_strlcpy (if_request.device1, master, sizeof (if_request.device1)); if_request.cmd = ADD_VLAN_CMD; if_request.u.VID = vid; @@ -1769,7 +1769,7 @@ nm_system_iface_compat_rem_vlan_device (const char *iface) } memset (&if_request, 0, sizeof (struct vlan_ioctl_args)); - strcpy (if_request.device1, iface); + g_strlcpy (if_request.device1, iface, sizeof (if_request.device1)); if_request.cmd = DEL_VLAN_CMD; if (ioctl (fd, SIOCSIFVLAN, &if_request) < 0) {