From d67d12ebe1996a74f33610eaf2d9f46258901c61 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Fri, 28 Apr 2017 19:26:59 +0200 Subject: [PATCH] libnm: fix comparison of pfm enum against zero Fixes compiler warning comparison of unsigned enum expression < 0 is always false [-Werror,-Wtautological-compare] Fixes: 6ef59b5b776690097d28538db17e0ff8a3df84d5 --- libnm-core/nm-setting-wireless-security.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libnm-core/nm-setting-wireless-security.c b/libnm-core/nm-setting-wireless-security.c index 1d07397878..8ddefba2f2 100644 --- a/libnm-core/nm-setting-wireless-security.c +++ b/libnm-core/nm-setting-wireless-security.c @@ -1031,8 +1031,8 @@ verify (NMSetting *setting, NMConnection *connection, GError **error) } } - if ( priv->pmf < 0 - || priv->pmf > NM_SETTING_WIRELESS_SECURITY_PMF_REQUIRED) { + G_STATIC_ASSERT_EXPR (((NMSettingWirelessSecurityPmf) -1) > 0); + if (priv->pmf > NM_SETTING_WIRELESS_SECURITY_PMF_REQUIRED) { g_set_error_literal (error, NM_CONNECTION_ERROR, NM_CONNECTION_ERROR_INVALID_PROPERTY,