fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-01-10 15:10:22 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

platform/tests: workaround routing-rules test failure due to suppress_prefixlen on older kernels

Browse source 
On Ubuntu 14.04 kernel (4.4.0-146-generic, x86_64) this easily causes
test failures:

    make -j 8 src/platform/tests/test-route-linux \
    && while true; do \
        NMTST_SEED_RANDOM= ./tools/run-nm-test.sh src/platform/tests/test-route-linux -p /route/rule \
        || break; \
    done

outputs:

    ...
    /route/rule/1:
    nmtst: initialize nmtst_get_rand() with NMTST_SEED_RAND=22892021
    OK
    /route/rule/2: >>> failing...
    >>> no fuzzy match between: [routing-rule,0x205ab30,1,+alive,+visible; [6] 0: from all suppress_prefixlen 8 none]
    >>>                    and: [routing-rule,0x205c0c0,1,+alive,+visible; [6] 0: from all suppress_prefixlen -1579099242 none]
    **
    test:ERROR:src/platform/tests/test-route.c:1695:test_rule: code should not be reached
This commit is contained in:
Thomas Haller 2019-05-02 09:11:43 +02:00
parent 0a0a8706f8
commit d5a2b70909
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/platform/tests/test-route.c
View file

@ -1345,8 +1345,7 @@ _rule_fuzzy_equal (const NMPObject *obj,
rr_co.tos = 0;
if (rr->ip_proto == 0)
rr_co.ip_proto = 0;
if (rr->suppress_prefixlen_inverse == 0)
rr_co.suppress_prefixlen_inverse = 0;
rr_co.suppress_prefixlen_inverse = rr->suppress_prefixlen_inverse;
if (rr->suppress_ifgroup_inverse == 0)
rr_co.suppress_ifgroup_inverse = 0;
if (!rr->uid_range_has)