fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-01-12 09:10:31 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

libnm: hide nm_setting_ip_config_next_valid_dns_option() function from headers

Browse source 
nm_setting_ip_config_next_valid_dns_option() API was added in libnm 1.2, but
it was never exported in the ABI of libnm. It thus was unusable, and any user
trying to link against it would have been unable to do so.

Hide the API now entirely. It doesn't seem a very nice API. If we want to
allow the user to validate option names, we should expose such a function
to validate an option (not to fetch the next valid option from a
profile).

Fixes: 019943bb5d ('libnm-core: add dns-options property to NMSettingIPConfig')
(cherry picked from commit e8e5c12480)
(cherry picked from commit 04946f71ea)
(cherry picked from commit 098e713ced)
This commit is contained in:
Thomas Haller 2020-09-22 17:54:51 +02:00
parent 343293ffcb
commit d32148fd66
No known key found for this signature in database
GPG key ID: 29C2366E4DFC5728
3 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
libnm-core/nm-core-internal.h
View file

@ -448,6 +448,9 @@ gboolean _nm_utils_dns_option_validate (const char *option, char **out_name,
const NMUtilsDNSOptionDesc *option_descs);
gssize _nm_utils_dns_option_find_idx (GPtrArray *array, const char *option);
int nm_setting_ip_config_next_valid_dns_option (NMSettingIPConfig *setting,
guint idx);
/*****************************************************************************/
typedef struct _NMUtilsStrStrDictKey NMUtilsStrStrDictKey;

2
libnm-core/nm-setting-ip-config.c
View file

@ -4003,8 +4003,6 @@ nm_setting_ip_config_get_dns_option (NMSettingIPConfig *setting, guint idx)
*
* Returns: the index, greater or equal than @idx, of the first valid
* DNS option, or -1 if no valid option is found
*
* Since: 1.2
**/
int
nm_setting_ip_config_next_valid_dns_option (NMSettingIPConfig *setting, guint idx)

2
libnm-core/nm-setting-ip-config.h
View file

@ -454,8 +454,6 @@ guint nm_setting_ip_config_get_num_dns_options (NMSettingIPConfig
gboolean nm_setting_ip_config_has_dns_options (NMSettingIPConfig *setting);
const char *nm_setting_ip_config_get_dns_option (NMSettingIPConfig *setting,
guint idx);
int nm_setting_ip_config_next_valid_dns_option (NMSettingIPConfig *setting,
guint idx);
gboolean nm_setting_ip_config_add_dns_option (NMSettingIPConfig *setting,
const char *dns_option);
void nm_setting_ip_config_remove_dns_option (NMSettingIPConfig *setting,