From d2b4a6c35b3b2d744dcb311d7d7fd5378e7b21c7 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Wed, 11 Jul 2018 15:55:06 +0200 Subject: [PATCH] connectivity: downgrade verbosity of error logging Such failures during connectivity checks, may happen frequently and due to external causes. Don't log with error level to avoid spamming the logfile. (cherry picked from commit ca9981eb5d0030a3356db67a8f161b5660869f39) --- src/nm-connectivity.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/nm-connectivity.c b/src/nm-connectivity.c index 389e72ad7c..16c1bc3bf8 100644 --- a/src/nm-connectivity.c +++ b/src/nm-connectivity.c @@ -247,7 +247,7 @@ curl_check_connectivity (CURLM *mhandle, int sockfd, int ev_bitmask) ret = curl_multi_socket_action (mhandle, sockfd, ev_bitmask, &running_handles); if (ret != CURLM_OK) - _LOGE ("connectivity check failed: %d", ret); + _LOGD ("connectivity check failed: %d", ret); while ((msg = curl_multi_info_read (mhandle, &m_left))) { @@ -257,7 +257,7 @@ curl_check_connectivity (CURLM *mhandle, int sockfd, int ev_bitmask) /* Here we have completed a session. Check easy session result. */ eret = curl_easy_getinfo (msg->easy_handle, CURLINFO_PRIVATE, (char **) &cb_data); if (eret != CURLE_OK) { - _LOGE ("curl cannot extract cb_data for easy handle, skipping msg"); + _LOGD ("curl cannot extract cb_data for easy handle, skipping msg"); continue; } @@ -576,7 +576,7 @@ update_config (NMConnectivity *self, NMConfigData *config_data) } else if (strcasecmp (scheme, "https") == 0) { _LOGW ("use of HTTPS for connectivity checking is not reliable and is discouraged (URI: %s)", uri); } else if (strcasecmp (scheme, "http") != 0) { - _LOGE ("scheme of '%s' uri does't use a scheme that is allowed for connectivity check.", uri); + _LOGE ("scheme of '%s' uri doesn't use a scheme that is allowed for connectivity check.", uri); uri = NULL; }