From d0db41c1d48ae326eb12217b553582b6dde19cd9 Mon Sep 17 00:00:00 2001 From: Beniamino Galvani Date: Mon, 7 Oct 2019 11:42:12 +0200 Subject: [PATCH] cli: fix crash in 'nmcli connection add' The connection type can be NULL. Fixes: e1ec22f74b1e ('cli: cleanup setting default interface-name') --- clients/cli/connections.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/clients/cli/connections.c b/clients/cli/connections.c index 2c05754d5a..67d9bef772 100644 --- a/clients/cli/connections.c +++ b/clients/cli/connections.c @@ -3752,11 +3752,11 @@ set_default_interface_name (NmCli *nmc, con_type = nm_setting_connection_get_connection_type (s_con); /* Set a sensible bond/team/bridge interface name by default */ - if (nm_streq (con_type, NM_SETTING_BOND_SETTING_NAME)) + if (nm_streq0 (con_type, NM_SETTING_BOND_SETTING_NAME)) default_name = "nm-bond"; - else if (nm_streq (con_type, NM_SETTING_TEAM_SETTING_NAME)) + else if (nm_streq0 (con_type, NM_SETTING_TEAM_SETTING_NAME)) default_name = "nm-team"; - else if (nm_streq (con_type, NM_SETTING_BRIDGE_SETTING_NAME)) + else if (nm_streq0 (con_type, NM_SETTING_BRIDGE_SETTING_NAME)) default_name = "nm-bridge"; else default_name = NULL;