From cfdb962ebdbd3e5855f2c5b29524f27539ea34b1 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Wed, 15 Nov 2017 18:17:58 +0100 Subject: [PATCH] ifcfg-rh: avoid coverity false positive in write_secrets() Comparing @secrets_keys indicates to coverity that it might be NULL. Below, we access @secrets_keys without check, and coverity doesn't realize that this cannot crash, because secrets_keys_n would be zero too. Anyway, this way we safe the sorting, in case we only have one element. --- src/settings/plugins/ifcfg-rh/nms-ifcfg-rh-writer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/settings/plugins/ifcfg-rh/nms-ifcfg-rh-writer.c b/src/settings/plugins/ifcfg-rh/nms-ifcfg-rh-writer.c index e413da1ef4..c4e65b4f0d 100644 --- a/src/settings/plugins/ifcfg-rh/nms-ifcfg-rh-writer.c +++ b/src/settings/plugins/ifcfg-rh/nms-ifcfg-rh-writer.c @@ -150,7 +150,7 @@ write_secrets (shvarFile *ifcfg, /* sort the keys. */ secrets_keys = (const char **) g_hash_table_get_keys_as_array (secrets, &secrets_keys_n); - if (secrets_keys) { + if (secrets_keys_n > 1) { g_qsort_with_data (secrets_keys, secrets_keys_n, sizeof (const char *),