fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-05-05 06:28:05 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

settings: drop redundant check from have_connection_for_device()

Browse source 
have_connection_for_device() really should just call nm_device_check_connection_compatible().
Note that nm_device_check_connection_compatible() of course checks the
connection type already, so this is redundant.

(cherry picked from commit 2a506d8a09)
This commit is contained in:
Thomas Haller 2019-08-07 13:02:48 +02:00
parent bad64d1cf6
commit cdb719c756
1 changed files with 0 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/settings/nm-settings.c
View file

@ -3386,12 +3386,6 @@ have_connection_for_device (NMSettings *self, NMDevice *device)
/* Find a wired connection matching for the device, if any */
c_list_for_each_entry (sett_conn, &priv->connections_lst_head, _connections_lst) {
NMConnection *connection = nm_settings_connection_get_connection (sett_conn);
const char *ctype;
ctype = nm_connection_get_connection_type (connection);
if (!NM_IN_STRSET (ctype, NM_SETTING_WIRED_SETTING_NAME,
NM_SETTING_PPPOE_SETTING_NAME))
continue;
if (!nm_device_check_connection_compatible (device, connection, NULL))
continue;