From cbaeadb0a4895e7a3d7d90811017de04bf1f115e Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Thu, 27 May 2021 09:29:21 +0200 Subject: [PATCH] libnm/docs: document nm_utils_is_uuid() as deprecated However, don't also use the NM_DEPRECATED_IN_1_32 macro, because that causes annoying compiler warnings. There is no replacement for the function in libnm, nor is it planned to add one. So users may still call it, but they are now warned by documentation that it may not be a good idea. --- src/libnm-core-impl/nm-utils.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/libnm-core-impl/nm-utils.c b/src/libnm-core-impl/nm-utils.c index 1bc44bb5de..d9956a4dff 100644 --- a/src/libnm-core-impl/nm-utils.c +++ b/src/libnm-core-impl/nm-utils.c @@ -4429,6 +4429,10 @@ nm_utils_iface_valid_name(const char *name) * * In older versions, nm_utils_is_uuid() did not accept %NULL as @str * argument. Don't pass %NULL if you run against older versions of libnm. + * + * Deprecated: 1.32: older versions of NetworkManager had a wrong + * understanding of what makes a valid UUID. This function can thus + * accept some inputs as valid, which in fact are not valid UUIDs. */ gboolean nm_utils_is_uuid(const char *str)