fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-04-30 23:48:05 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

all: fix various wrong "return FALSE" for returning pointers

Browse source
This commit is contained in:
Thomas Haller 2023-05-02 07:56:28 +02:00
parent 6428ee04a8
commit cb6f8b987c
No known key found for this signature in database
GPG key ID: 29C2366E4DFC5728
2 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/libnm-client-impl/nm-conn-utils.c
View file

@ -170,7 +170,7 @@ nm_conn_wireguard_import(const char *filename, GError **error)
NM_UTILS_ERROR_UNKNOWN,
_("The name of the WireGuard config must be a valid interface "
"name followed by \".conf\""));
return FALSE;
return NULL;
}
if (!nm_utils_file_get_contents(-1,
@ -250,7 +250,7 @@ nm_conn_wireguard_import(const char *filename, GError **error)
current_peer_start_line_nr,
filename,
error))
return FALSE;
return NULL;
line_context = LINE_CONTEXT_INTERFACE;
continue;
}
@ -261,7 +261,7 @@ nm_conn_wireguard_import(const char *filename, GError **error)
current_peer_start_line_nr,
filename,
error))
return FALSE;
return NULL;
current_peer_start_line_nr = line_nr;
current_peer = nm_wireguard_peer_new();
line_context = LINE_CONTEXT_PEER;
@ -454,7 +454,7 @@ fail_invalid_line:
_("unrecognized line at %s:%zu"),
filename,
line_nr);
return FALSE;
return NULL;
fail_invalid_value:
nm_utils_error_set(error,
NM_UTILS_ERROR_INVALID_ARGUMENT,
@ -462,7 +462,7 @@ fail_invalid_value:
matched_key,
filename,
line_nr);
return FALSE;
return NULL;
fail_invalid_secret:
nm_utils_error_set(error,
NM_UTILS_ERROR_INVALID_ARGUMENT,
@ -470,7 +470,7 @@ fail_invalid_secret:
matched_key,
filename,
line_nr);
return FALSE;
return NULL;
}
if (!_wg_complete_peer(&data_peers,
@ -478,7 +478,7 @@ fail_invalid_secret:
current_peer_start_line_nr,
filename,
error))
return FALSE;
return NULL;
connection = nm_simple_connection_new();
s_con = NM_SETTING_CONNECTION(nm_setting_connection_new());
@ -592,7 +592,7 @@ fail_invalid_secret:
NM_UTILS_ERROR_INVALID_ARGUMENT,
_("Failed to create WireGuard connection: %s"),
local->message);
return FALSE;
return NULL;
}
return g_steal_pointer(&connection);

2
src/libnm-glib-aux/nm-ref-string.h
View file

@ -53,7 +53,7 @@ nmtst_ref_string_find(const char *cstr)
{
/* WARNING: only use for testing. See nmtst_ref_string_find_len() why. */
if (!cstr)
return FALSE;
return NULL;
return nmtst_ref_string_find_len(cstr, strlen(cstr));
}