From cb2ab420a24a86ccc5efcdcbf9d4ae1c54a76ca7 Mon Sep 17 00:00:00 2001
From: Thomas Haller <thaller@redhat.com>
Date: Sat, 30 Apr 2022 22:36:08 +0200
Subject: [PATCH] dhcp: don't assert against untrusted data in
 maybe_add_option()

---
 src/core/dhcp/nm-dhcp-client.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/core/dhcp/nm-dhcp-client.c b/src/core/dhcp/nm-dhcp-client.c
index 52a46b6633..888dc3f4e8 100644
--- a/src/core/dhcp/nm-dhcp-client.c
+++ b/src/core/dhcp/nm-dhcp-client.c
@@ -814,7 +814,8 @@ maybe_add_option(NMDhcpClient *self, GHashTable *hash, const char *key, GVariant
 {
     char *str_value = NULL;
 
-    g_return_if_fail(g_variant_is_of_type(value, G_VARIANT_TYPE_BYTESTRING));
+    if (!g_variant_is_of_type(value, G_VARIANT_TYPE_BYTESTRING))
+        return;
 
     if (g_str_has_prefix(key, OLD_TAG))
         return;