fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-05-07 13:08:10 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

device: allow ipv6ll address to be set for disconnected devices

Browse source 
Commit f85941ee91 ("device: don't try to generate ipv6ll address for
disconnected devices") disabled the generation of IPv6 link-local
addresses for disconnected devices to fix a crash. However that broke
the following:

 $ ip a f dev eth0
 $ systemctl start NetworkManager
 $ nmcli d
 DEVICE  TYPE      STATE         CONNECTION
 eth0    ethernet  disconnected  eth0
 $ ip a a dev eth0 2001::42/64
 $ ip a show eth0
 4: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq_codel state UP group default qlen 1000
     link/ether 52:52:00:61:32:81 brd ff:ff:ff:ff:ff:ff
     inet6 2001::42/64 scope global
        valid_lft forever preferred_lft forever
     (no link-local address)

Revert that change.

Fixes: f85941ee91
(cherry picked from commit 75406d1760)
This commit is contained in:
Beniamino Galvani 2016-07-07 16:29:25 +02:00
parent a7a206b8e2
commit cab63901fa
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/devices/nm-device.c
View file

@ -9099,8 +9099,7 @@ queued_ip6_config_change (gpointer user_data)
g_object_ref (self); g_object_ref (self);
update_ip6_config (self, FALSE); update_ip6_config (self, FALSE);
if ( priv->state > NM_DEVICE_STATE_DISCONNECTED if ( priv->state < NM_DEVICE_STATE_DEACTIVATING
&& priv->state < NM_DEVICE_STATE_DEACTIVATING
&& nm_platform_link_get (NM_PLATFORM_GET, priv->ifindex)) { && nm_platform_link_get (NM_PLATFORM_GET, priv->ifindex)) {
/* Handle DAD failures */ /* Handle DAD failures */
for (iter = priv->dad6_failed_addrs; iter; iter = g_slist_next (iter)) { for (iter = priv->dad6_failed_addrs; iter; iter = g_slist_next (iter)) {