manager: error out on wrong connection passed to AddAndActivate

This commit is contained in:
Lubomir Rintel 2023-03-16 16:41:32 +01:00
parent 3c548dd081
commit c92f9963c8

View file

@ -6592,11 +6592,14 @@ impl_manager_add_and_activate_connection(NMDBusObject *obj,
* validate_activation_request()).
*/
incompl_conn = nm_simple_connection_new();
if (settings && g_variant_n_children(settings))
_nm_connection_replace_settings(incompl_conn,
settings,
NM_SETTING_PARSE_FLAGS_STRICT,
NULL);
if (settings && g_variant_n_children(settings)) {
if (!_nm_connection_replace_settings(incompl_conn,
settings,
NM_SETTING_PARSE_FLAGS_STRICT,
&error)) {
goto error;
}
}
subject = validate_activation_request(self,
invocation,