fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2025-12-25 01:20:07 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

core: avoid duplicate lookup in nm_utils_strdict_to_variant()

Browse source 
Collect the full list of key and values, while sorting the key.
This way, we don't need to lookup the values by key later.
This commit is contained in:
Thomas Haller 2020-02-20 15:11:20 +01:00
parent f13c7e3bbd
commit c8d043dd94
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/nm-core-utils.c
View file

@ -4055,18 +4055,18 @@ GVariant *
nm_utils_strdict_to_variant (GHashTable *options)
{
GVariantBuilder builder;
gs_free const char **keys = NULL;
gs_free NMUtilsNamedValue *values = NULL;
guint i;
guint nkeys;
guint n;
keys = nm_utils_strdict_get_keys (options, TRUE, &nkeys);
values = nm_utils_named_values_from_str_dict (options, &n);
g_variant_builder_init (&builder, G_VARIANT_TYPE ("a{sv}"));
for (i = 0; i < nkeys; i++) {
for (i = 0; i < n; i++) {
g_variant_builder_add (&builder,
"{sv}",
keys[i],
g_variant_new_string (g_hash_table_lookup (options, keys[i])));
values[i].name,
g_variant_new_string (values[i].value_str));
}
return g_variant_builder_end (&builder);
}