fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-01-02 22:50:12 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

device: prefer IPv6 not-deprecated addresses for hostname lookup

Browse source 
In presence of a IPv6 deprecated address and a non-deprecated one, the
latter will be used by kernel for new connections according to RFC
6724 section 5 (Source Address Selection). Prefer it also to lookup a
hostname via reverse DNS.

While at it, also prefer non-link-local addresses over link-local
ones.

(cherry picked from commit 3c55db886a)
This commit is contained in:
Beniamino Galvani 2021-06-10 22:56:02 +02:00
parent 2ca56c9bbd
commit c8c7e8320b
1 changed files with 27 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
src/core/devices/nm-device.c
View file

@ -17799,13 +17799,36 @@ nm_device_get_hostname_from_dns_lookup(NMDevice *self, int addr_family, gboolean
priv->hostname_resolver_x[IS_IPv4] = resolver;
}
/* Determine the first address of the interface and
* whether it changed from the previous lookup */
/* Determine the most suitable address of the interface
* and whether it changed from the previous lookup */
ip_config = priv->ip_config_x[IS_IPv4];
if (ip_config) {
const NMPlatformIPAddress *addr;
const NMPlatformIPAddress *addr = NULL;
if (IS_IPv4) {
addr = nm_ip_config_get_first_address(ip_config);
} else {
/* For IPv6 prefer, in order:
* - !link-local, !deprecated
* - !link-local, deprecated
* - link-local
*/
addr = nm_ip_config_find_first_address(ip_config,
NM_PLATFORM_MATCH_WITH_ADDRTYPE_NORMAL
| NM_PLATFORM_MATCH_WITH_ADDRSTATE_NORMAL);
if (!addr) {
addr = nm_ip_config_find_first_address(
ip_config,
NM_PLATFORM_MATCH_WITH_ADDRTYPE_NORMAL
| NM_PLATFORM_MATCH_WITH_ADDRSTATE_DEPRECATED);
}
if (!addr) {
addr = nm_ip_config_find_first_address(ip_config,
NM_PLATFORM_MATCH_WITH_ADDRTYPE_LINKLOCAL
| NM_PLATFORM_MATCH_WITH_ADDRSTATE__ANY);
}
}
addr = nm_ip_config_get_first_address(ip_config);
if (addr) {
new_address = g_inet_address_new_from_bytes(addr->address_ptr,
IS_IPv4 ? G_SOCKET_FAMILY_IPV4