From c896973debc4e7ec63e35b9e0bbefc083c5b9d27 Mon Sep 17 00:00:00 2001 From: Beniamino Galvani Date: Fri, 17 Sep 2021 17:22:00 +0200 Subject: [PATCH] platform: drop test-tc-fake It doesn't seem useful to have a copy of the test which does nothing. --- Makefile.am | 6 ------ src/core/platform/tests/meson.build | 1 - src/core/platform/tests/test-tc.c | 12 +++++------- 3 files changed, 5 insertions(+), 14 deletions(-) diff --git a/Makefile.am b/Makefile.am index 22634626d0..05406d674e 100644 --- a/Makefile.am +++ b/Makefile.am @@ -4180,7 +4180,6 @@ check_programs += \ src/core/platform/tests/test-platform-general \ src/core/platform/tests/test-route-fake \ src/core/platform/tests/test-route-linux \ - src/core/platform/tests/test-tc-fake \ src/core/platform/tests/test-tc-linux \ $(NULL) @@ -4236,11 +4235,6 @@ src_core_platform_tests_test_route_linux_CPPFLAGS = $(src_core_tests_cppflags_li src_core_platform_tests_test_route_linux_LDFLAGS = $(src_core_platform_tests_ldflags) src_core_platform_tests_test_route_linux_LDADD = $(src_core_platform_tests_libadd) -src_core_platform_tests_test_tc_fake_SOURCES = src/core/platform/tests/test-tc.c -src_core_platform_tests_test_tc_fake_CPPFLAGS = $(src_core_tests_cppflags_fake) -src_core_platform_tests_test_tc_fake_LDFLAGS = $(src_core_platform_tests_ldflags) -src_core_platform_tests_test_tc_fake_LDADD = $(src_core_platform_tests_libadd) - src_core_platform_tests_test_tc_linux_SOURCES = src/core/platform/tests/test-tc.c src_core_platform_tests_test_tc_linux_CPPFLAGS = $(src_core_tests_cppflags_linux) src_core_platform_tests_test_tc_linux_LDFLAGS = $(src_core_platform_tests_ldflags) diff --git a/src/core/platform/tests/meson.build b/src/core/platform/tests/meson.build index 5d55707a08..8824ed2f67 100644 --- a/src/core/platform/tests/meson.build +++ b/src/core/platform/tests/meson.build @@ -14,7 +14,6 @@ test_units = [ ['test-platform-general', 'test-platform-general.c', test_c_flags, default_test_timeout], ['test-route-fake', 'test-route.c', test_fake_c_flags, default_test_timeout], ['test-route-linux', 'test-route.c', test_linux_c_flags, default_test_timeout], - ['test-tc-fake', 'test-tc.c', test_fake_c_flags, default_test_timeout], ['test-tc-linux', 'test-tc.c', test_linux_c_flags, default_test_timeout], ] diff --git a/src/core/platform/tests/test-tc.c b/src/core/platform/tests/test-tc.c index ddac2642b3..8b7e4d4a94 100644 --- a/src/core/platform/tests/test-tc.c +++ b/src/core/platform/tests/test-tc.c @@ -202,7 +202,7 @@ test_qdisc_tbf(void) /*****************************************************************************/ -NMTstpSetupFunc const _nmtstp_setup_platform_func = SETUP; +NMTstpSetupFunc const _nmtstp_setup_platform_func = nm_linux_platform_setup; void _nmtstp_init_tests(int *argc, char ***argv) @@ -213,10 +213,8 @@ _nmtstp_init_tests(int *argc, char ***argv) void _nmtstp_setup_tests(void) { - if (nmtstp_is_root_test()) { - nmtstp_env1_add_test_func("/link/qdisc/1", test_qdisc1, TRUE); - nmtstp_env1_add_test_func("/link/qdisc/fq_codel", test_qdisc_fq_codel, TRUE); - nmtstp_env1_add_test_func("/link/qdisc/sfq", test_qdisc_sfq, TRUE); - nmtstp_env1_add_test_func("/link/qdisc/tbf", test_qdisc_tbf, TRUE); - } + nmtstp_env1_add_test_func("/link/qdisc/1", test_qdisc1, TRUE); + nmtstp_env1_add_test_func("/link/qdisc/fq_codel", test_qdisc_fq_codel, TRUE); + nmtstp_env1_add_test_func("/link/qdisc/sfq", test_qdisc_sfq, TRUE); + nmtstp_env1_add_test_func("/link/qdisc/tbf", test_qdisc_tbf, TRUE); }