settings: remove duplicated dbus_g_method_return()

Could cause a crash when updating a connection, since dbus-glib may
clear DBusGMethodInvocation resources during this method.  Since
update_complete() is actually our completion/cleanup handler for
this operation chain, we can remove the standalone call to
dbus_g_method_return().
This commit is contained in:
Dan Williams 2013-05-29 14:53:45 -05:00
parent 7f6d10f3c3
commit c7c8655832

View file

@ -1205,8 +1205,6 @@ con_update_cb (NMSettingsConnection *self,
GUINT_TO_POINTER (NM_SETTING_SECRET_FLAG_AGENT_OWNED));
nm_agent_manager_save_secrets (info->agent_mgr, for_agent, TRUE, info->sender_uid);
g_object_unref (for_agent);
dbus_g_method_return (info->context);
}
update_complete (self, info, error);